Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more tests for ante sig #6462

Merged
merged 10 commits into from
Jun 24, 2020
Merged

Conversation

sahith-narahari
Copy link
Contributor

Description

Ref: #6428


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #6462 into aaronc/6213-ante-sig-verify will increase coverage by 0.04%.
The diff coverage is 55.55%.

@@                       Coverage Diff                       @@
##           aaronc/6213-ante-sig-verify    #6462      +/-   ##
===============================================================
+ Coverage                        55.77%   55.81%   +0.04%     
===============================================================
  Files                              466      466              
  Lines                            27849    27850       +1     
===============================================================
+ Hits                             15532    15544      +12     
+ Misses                           11207    11192      -15     
- Partials                          1110     1114       +4     

x/auth/ante/sigverify.go Outdated Show resolved Hide resolved
@clevinson clevinson added this to the v0.39 milestone Jun 17, 2020
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Just a few small comments.

x/auth/types/stdtx_test.go Outdated Show resolved Hide resolved
x/auth/signing/verify_test.go Outdated Show resolved Hide resolved
@anilcse anilcse requested a review from aaronc June 23, 2020 21:11
@anilcse anilcse merged commit b20c3f5 into aaronc/6213-ante-sig-verify Jun 24, 2020
@anilcse anilcse deleted the sahith/6428-add-tests branch June 24, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants