-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/rootmulti: add SimpleProofsFromMap #6481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
June 22, 2020 16:21
tac0turtle
removed request for
aaronc,
alessio,
clevinson,
jgimeno,
alexanderbez and
fedekunze
June 22, 2020 16:22
Codecov Report
@@ Coverage Diff @@
## master #6481 +/- ##
==========================================
+ Coverage 56.31% 56.34% +0.02%
==========================================
Files 470 470
Lines 28178 28232 +54
==========================================
+ Hits 15869 15907 +38
- Misses 11187 11200 +13
- Partials 1122 1125 +3 |
…/cosmos-sdk into marko/simpleProofsFromMap
tac0turtle
force-pushed
the
marko/simpleProofsFromMap
branch
from
June 22, 2020 16:38
f66e833
to
b33003d
Compare
tac0turtle
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Jun 22, 2020
AdityaSripal
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
fedekunze
reviewed
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you add a Changelog entry? 🙏
…/cosmos-sdk into marko/simpleProofsFromMap
fedekunze
reviewed
Jun 23, 2020
fedekunze
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings simpleProofsFromMap to the sdk. This will be removed in 0.34 release of tendermint.
closes: #XXXX