Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/distribution: gRPC query service #6600

Merged
merged 44 commits into from
Jul 13, 2020
Merged

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 4, 2020

Description

ref: #5921

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@atheeshp atheeshp added the WIP label Jul 4, 2020
@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #6600 into master will increase coverage by 3.09%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #6600      +/-   ##
==========================================
+ Coverage   55.38%   58.47%   +3.09%     
==========================================
  Files         341      509     +168     
  Lines       19497    30861   +11364     
==========================================
+ Hits        10799    18047    +7248     
- Misses       7932    11472    +3540     
- Partials      766     1342     +576     

@aaronc aaronc mentioned this pull request Jul 6, 2020
43 tasks
@alexanderbez alexanderbez removed the WIP label Jul 7, 2020
@sahith-narahari sahith-narahari self-assigned this Jul 12, 2020
proto/cosmos/distribution/distribution.proto Outdated Show resolved Hide resolved
x/distribution/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/distribution/keeper/grpc_query.go Outdated Show resolved Hide resolved
@atheeshp atheeshp marked this pull request as ready for review July 13, 2020 11:32
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez added the C:x/distribution distribution module related label Jul 13, 2020
x/distribution/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/distribution/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/distribution/keeper/grpc_query.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just one small question

x/distribution/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/distribution/keeper/grpc_query.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 13, 2020
@mergify mergify bot merged commit be111ef into master Jul 13, 2020
@mergify mergify bot deleted the atheesh/5921-grpc-x-distribution branch July 13, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants