ibc-transfer: enable transfer parameter #6607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will block this PR until #6641 is merged |
Codecov Report
@@ Coverage Diff @@
## master #6607 +/- ##
==========================================
- Coverage 54.76% 54.72% -0.04%
==========================================
Files 537 539 +2
Lines 36687 36770 +83
==========================================
+ Hits 20090 20121 +31
- Misses 14958 15008 +50
- Partials 1639 1641 +2 |
fedekunze
requested review from
aaronc,
alessio,
alexanderbez,
clevinson and
jgimeno
as code owners
fedekunze
added
the
A:automerge
fedekunze
requested review from
AdityaSripal,
cwgoes,
anilcse,
amaury1093,
atheeshp,
blushi and
colin-axner
colin-axner
reviewed
Aug 18, 2020
| @@ -60,3 +60,13 @@ message DenomTrace { | |||
| // base denomination of the relayed fungible token. | |||
| string base_denom = 2; | |||
| } | |||
|
|
|||
| // Params defines the set of IBC transfer parameters. | |||
| // NOTE: To prevent a single token from being transferred, set the TransfersEnabled parameter to | |||
There was a problem hiding this comment.
I think this note could be slightly more clear:
- to block any cross-chain transfers -> disable ibc-transfer param
- to block intrachain transfers for a specific denom -> disable bank param for that denom
9 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* ibc-transfer: enable transfer parameter * param_test.go * update tests and types * gRPC test * relay logic and spec update * fix tests * unused param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #6591
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes