Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crisis: In-Process CLI Integration Tests #6634

Merged
merged 4 commits into from
Jul 8, 2020
Merged

x/crisis: In-Process CLI Integration Tests #6634

merged 4 commits into from
Jul 8, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 7, 2020 •
edited
Loading

Description

ref: #6423

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added C:CLI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:x/crisis A:automerge Automatically merge PR once all prerequisites pass. labels Jul 7, 2020
@aaronc aaronc mentioned this pull request Jul 7, 2020
Closed
19 tasks
@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #6634 into master will increase coverage by 0.00%.
The diff coverage is 64.70%.

@@           Coverage Diff           @@
##           master    #6634   +/-   ##
=======================================
  Coverage   57.73%   57.74%           
=======================================
  Files         496      497    +1     
  Lines       29735    29767   +32     
=======================================
+ Hits        17167    17188   +21     
- Misses      11332    11342   +10     
- Partials     1236     1237    +1

@alexanderbez alexanderbez marked this pull request as ready for review July 8, 2020 01:35
@mergify mergify bot merged commit 3de1c7d into master Jul 8, 2020
@mergify mergify bot deleted the bez/6423-in-process-cli-tests-crisis branch July 8, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@anilcse anilcse anilcse approved these changes

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@clevinson clevinson Awaiting requested review from clevinson

@jgimeno jgimeno Awaiting requested review from jgimeno

@sahith-narahari sahith-narahari Awaiting requested review from sahith-narahari

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/crisis Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexanderbez @alessio @anilcse @fedekunze