Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/slashing: In-Process CLI Integration Tests #6702

Merged
merged 11 commits into from
Jul 14, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 13, 2020

Description

ref: #6423

Note, there were bugs in some of the Proto schemas WRT to JSON and YAML tags, which I fixed.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added C:CLI C:x/slashing Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. A:automerge Automatically merge PR once all prerequisites pass. labels Jul 13, 2020
@aaronc aaronc mentioned this pull request Jul 13, 2020
19 tasks
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #6702 into master will increase coverage by 0.86%.
The diff coverage is 41.37%.

@@            Coverage Diff             @@
##           master    #6702      +/-   ##
==========================================
+ Coverage   57.68%   58.54%   +0.86%     
==========================================
  Files          94      511     +417     
  Lines        6217    30981   +24764     
==========================================
+ Hits         3586    18139   +14553     
- Misses       2466    11495    +9029     
- Partials      165     1347    +1182     

@alexanderbez alexanderbez merged commit 6bd36c8 into master Jul 14, 2020
@alexanderbez alexanderbez deleted the bez/6423-in-process-cli-slashing branch July 14, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/slashing Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants