Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/params: CLI Refactor & In-Process Tests #6720

Merged
merged 5 commits into from
Jul 14, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 14, 2020

Description

ref: #6423


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added C:CLI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:x/params labels Jul 14, 2020
@aaronc aaronc mentioned this pull request Jul 14, 2020
19 tasks
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #6720 into master will increase coverage by 0.04%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master    #6720      +/-   ##
==========================================
+ Coverage   59.19%   59.23%   +0.04%     
==========================================
  Files         512      512              
  Lines       31295    31299       +4     
==========================================
+ Hits        18525    18541      +16     
+ Misses      11363    11347      -16     
- Partials     1407     1411       +4     

@alessio alessio merged commit 44f1482 into master Jul 14, 2020
@alessio alessio deleted the bez/6423-in-process-cli-params branch July 14, 2020 20:52
Mr-Leshiy pushed a commit to adoriasoft/cosmos-sdk that referenced this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/params Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants