Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic camelCasing in proto JSON #6833

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Disable automatic camelCasing in proto JSON #6833

merged 1 commit into from
Jul 23, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jul 23, 2020

closes: #6826


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc added C:Encoding A:automerge Automatically merge PR once all prerequisites pass. labels Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #6833 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6833   +/-   ##
=======================================
  Coverage   61.42%   61.42%           
=======================================
  Files         509      509           
  Lines       31457    31457           
=======================================
  Hits        19321    19321           
  Misses      10637    10637           
  Partials     1499     1499           

@aaronc aaronc marked this pull request as ready for review July 23, 2020 20:44
@mergify mergify bot merged commit b20b26d into master Jul 23, 2020
@mergify mergify bot deleted the aaronc/6826 branch July 23, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update make proto-gen JSON naming
3 participants