0.39->0.40 CLI migrate command
#6839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6839 +/- ##
==========================================
+ Coverage 55.11% 55.23% +0.11%
==========================================
Files 588 590 +2
Lines 36800 36914 +114
==========================================
+ Hits 20284 20390 +106
- Misses 14415 14420 +5
- Partials 2101 2104 +3 |
amaury1093
force-pushed
the
am-6751-migrate
branch
from
2ea1842 to
392c722
Compare
amaury1093
force-pushed
the
am-6751-migrate
branch
from
392c722 to
09307ad
Compare
amaury1093
commented
Jul 30, 2020
| @@ -116,10 +116,10 @@ message ValidatorSlashEventRecord { | |||
| ]; | |||
| uint64 height = 2; | |||
| uint64 period = 3; | |||
| ValidatorSlashEvent event = 4 [ | |||
| ValidatorSlashEvent validator_slash_event = 4 [ | |||
There was a problem hiding this comment.
This was validator_slash_event in v0.39
don't want to create a migrate script for this
9 tasks
amaury1093
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
amaury1093
commented
Sep 25, 2020
|
I tried updating a |
anilcse
reviewed
Sep 28, 2020
amaury1093
added
the
A:automerge
alessio
reviewed
Oct 2, 2020
alessio
reviewed
Oct 2, 2020
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #6751
What I did: checked out tag
v0.39.0, looked into allx/**/types/genesis.gostructs , and compared them to latest master's genesis structs (defined in proto files).Also:
Migratefunctions now take aclient.Context. It's only use in 0.40, to decide which JSON (amino or proto) to output.Update needed for:
If you can think of other genesis state's that I might have forgot, please shout.
depends on:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes