x/evidence genesis protobuf migration #6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6864 +/- ##
==========================================
+ Coverage 61.37% 61.40% +0.03%
==========================================
Files 510 511 +1
Lines 31845 31888 +43
==========================================
+ Hits 19544 19582 +38
- Misses 10766 10767 +1
- Partials 1535 1539 +4 |
blushi
requested review from
aaronc,
amaury1093,
anilcse,
atheeshp and
sahith-narahari
blushi
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
fedekunze
reviewed
Jul 29, 2020
aaronc
requested changes
Jul 29, 2020
There was a problem hiding this comment.
Just requesting the same changes as @fedekunze but otherwise LGTM
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
fedekunze
approved these changes
Jul 29, 2020
fedekunze
added
the
A:automerge
aaronc
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #5917
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes