Add swagger for gRPC REST #7075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
reviewed
Aug 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #7075 +/- ##
==========================================
- Coverage 54.78% 53.85% -0.94%
==========================================
Files 563 418 -145
Lines 38624 30117 -8507
==========================================
- Hits 21162 16219 -4943
+ Misses 15730 12608 -3122
+ Partials 1732 1290 -442 |
…21-swagger-gen # Conflicts: # contrib/devtools/Makefile # go.mod # go.sum
anilcse
reviewed
Aug 22, 2020
amaury1093
reviewed
Aug 24, 2020
| @@ -0,0 +1,90 @@ | |||
| { | |||
| "swagger": "2.0", | |||
There was a problem hiding this comment.
If i'm not mistaken, there's a new version 3, rebranded to OpenAPI. Why don't we use v3 instead? Maybe the merging issue will not even be relevant anymore.
Edit: that's why grpc-ecosystem/grpc-gateway#441. Keeping this comment for an FYI.
25 tasks
amaury1093
suggested changes
Aug 27, 2020
alexanderbez
added
T:Docs
fedekunze
reviewed
Aug 27, 2020
fedekunze
approved these changes
Aug 28, 2020
fedekunze
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5921
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes