Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Any for PubKey in proto Tx's #7076

Closed
wants to merge 7 commits into from
Closed

Use Any for PubKey in proto Tx's #7076

wants to merge 7 commits into from

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Aug 17, 2020

ref: #6928

needs #7008


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc added T: Proto Breaking Protobuf breaking changes: generally don't do this! C:x/auth labels Aug 17, 2020
@amaury1093 amaury1093 mentioned this pull request Sep 4, 2020
9 tasks
@amaury1093
Copy link
Contributor

superseded by #7276

@amaury1093 amaury1093 closed this Sep 17, 2020
@amaury1093 amaury1093 deleted the aaronc/tx-any-pubkey branch September 17, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/auth T: Proto Breaking Protobuf breaking changes: generally don't do this!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants