Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds x/gov missing cli tests #7128

Merged
merged 22 commits into from
Sep 18, 2020
Merged

Adds x/gov missing cli tests #7128

merged 22 commits into from
Sep 18, 2020

Conversation

atheeshp
Copy link
Contributor

ref: #7067

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #7128 into master will increase coverage by 0.97%.
The diff coverage is 21.05%.

@@            Coverage Diff             @@
##           master    #7128      +/-   ##
==========================================
+ Coverage   54.86%   55.84%   +0.97%     
==========================================
  Files         586      586              
  Lines       35958    35967       +9     
==========================================
+ Hits        19728    20084     +356     
+ Misses      14310    13914     -396     
- Partials     1920     1969      +49     

@atheeshp atheeshp marked this pull request as ready for review September 18, 2020 11:07
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @atheeshp!

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 18, 2020
@mergify mergify bot merged commit 34bbf4d into master Sep 18, 2020
@mergify mergify bot deleted the atheesh/7067-gov-cli-tests branch September 18, 2020 14:26
@alessio alessio mentioned this pull request Sep 18, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants