-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register x/mint
gRPC gateway routes
#7214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7214 +/- ##
==========================================
- Coverage 54.68% 54.66% -0.03%
==========================================
Files 569 571 +2
Lines 39248 39297 +49
==========================================
+ Hits 21463 21481 +18
- Misses 16011 16039 +28
- Partials 1774 1777 +3 |
anilcse
changed the title
Adds grpc tests for x/mint
Register Sep 1, 2020
x/mint
gRPC gateway routes
anilcse
added
C: gRPC
Issues and PRs related to the gRPC service and HTTP gateway.
REST
labels
Sep 1, 2020
25 tasks
atheeshp
requested review from
aaronc,
alessio and
alexanderbez
as code owners
September 3, 2020 11:18
amaury1093
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Sep 3, 2020
amaury1093
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
alexanderbez
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
C: gRPC
Issues and PRs related to the gRPC service and HTTP gateway.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #5921
follow-up: #7019
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes