Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register grpc routes for x/{slashing, params} #7223

Merged
merged 7 commits into from
Sep 4, 2020

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Sep 2, 2020

ref: #5921
follow-up: #7019

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #7223 into master will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7223      +/-   ##
==========================================
- Coverage   54.77%   54.68%   -0.09%     
==========================================
  Files         565      569       +4     
  Lines       39138    39248     +110     
==========================================
+ Hits        21436    21463      +27     
- Misses      15933    16011      +78     
- Partials     1769     1774       +5     

@atheeshp atheeshp marked this pull request as ready for review September 3, 2020 11:15
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/params/client/rest/grpc_query_test.go Show resolved Hide resolved
x/slashing/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 3, 2020
x/params/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved
x/params/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved
x/slashing/client/rest/grpc_query_test.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit c1b975e into master Sep 4, 2020
@mergify mergify bot deleted the atheesh/5921-slashing-grpc-register branch September 4, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants