Cleanup of evidence types #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
aaronc,
amaury1093,
blushi,
anilcse and
cwgoes
robert-zaremba
requested review from
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7251 +/- ##
==========================================
- Coverage 55.14% 55.13% -0.01%
==========================================
Files 584 584
Lines 40512 40506 -6
==========================================
- Hits 22341 22335 -6
Misses 16301 16301
Partials 1870 1870 |
2 tasks
tac0turtle
reviewed
Sep 7, 2020
tac0turtle
reviewed
Sep 7, 2020
tac0turtle
approved these changes
Sep 7, 2020
alexanderbez
suggested changes
Sep 7, 2020
There was a problem hiding this comment.
Looks great @robert-zaremba! I just think we need to rename that one method.
Also, @marbar3778 what's up with codecov? It made this PR very hard to review.
alexanderbez
added
C:x/evidence
A:automerge
New feature I guess. Ill look into removing it tomorrow, its really annoying |
16 tasks
Handle the EvidenceType_LIGHT_CLIENT_ATTACK same as Duplicate Vote. + Bump Tendermint version to the latest master + Update Tendermint breaking changes (eg: RPC config update) + Update to new abci type definitions
robert-zaremba
force-pushed
the
robert/evidence-v40-handling
branch
from
c9d0d00 to
1565339
Compare
tac0turtle
removed
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
abciandtendermint/typestypes.EvidenceType_LIGHT_CLIENT_ATTACKsame as Duplicate Vote.closes: #7190
relates to: tendermint/tendermint#5288
NOTE:
Tendermint release v0.34 is blocked by some other tasks. That being said, the
evidenceupdates on Tendermint side are done. Since we are in rush to have SDK Stargate RC, I didn't break this PR into 2 independent PR (tendermint update + evidence update).Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes