Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return empty store tree on non-existing version #7415
Return empty store tree on non-existing version #7415
Changes from all commits
085ab67
8c75acf
4f2c638
f16c094
c9e1464
30193c8
8d51054
de349ad
8fa352c
8c0bc0b
508457f
40b2caf
28d866a
e865488
67fde03
95b0361
691aeaf
230839c
0deaf8a
308b7f0
fe79634
4fc58f4
9cbb46c
4467d50
1c91c46
3d0612a
dd6e2a2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will probably have to be modified once IAVL 0.15 is released. In 0.14, loading a missing version from an empty tree (no versions) does not error, which has been changed/fixed for the 0.15 line: cosmos/iavl#317
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. We'll just have to update this once that version is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check isn't strictly necessary, since
LoadStore()
is equivalent toLoadStoreWithInitialVersion(..., 0)
. But might be good to be explicit about it anyway.