Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyring-dir flag #7485

Merged
merged 11 commits into from
Oct 8, 2020
Merged

keyring-dir flag #7485

merged 11 commits into from
Oct 8, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Oct 8, 2020

Description

Operators may wish to have their Keyring & client material reside in a different directory than the directory dictated by the --home flag. Introduce a new --keyring-dir flag.

replaces: #7436

/cc @michaelfig


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez marked this pull request as ready for review October 8, 2020 13:53
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #7485 into master will decrease coverage by 3.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7485      +/-   ##
==========================================
- Coverage   56.01%   52.86%   -3.16%     
==========================================
  Files         591      437     -154     
  Lines       37188    27345    -9843     
==========================================
- Hits        20831    14456    -6375     
+ Misses      14233    11405    -2828     
+ Partials     2124     1484     -640     

@alexanderbez
Copy link
Contributor Author

Need to update some tests. Will try to get to this asap @michaelfig

@jackzampolin jackzampolin added this to the v0.40 [Stargate] milestone Oct 8, 2020
@michaelfig
Copy link
Contributor

This PR currently doesn't work for me:

soil:cosmic-swingset michael$ ./bin/ag-chain-cosmos --home=t1/n0 --keyring-dir=t1/bootstrap gentx --keyring-backend=test bootstrap --amount=1000000uagstake --chain-id=agoric
Error: failed to fetch 'bootstrap' from the keyring: The specified item could not be found in the keyring
Usage:
[...]
soil:cosmic-swingset michael$ ./bin/ag-chain-cosmos --home=t1/n0 --keyring-dir=t1/bootstrap --keyring-backend=test keys list
[]

soil:cosmic-swingset michael$ ./bin/ag-chain-cosmos --home=t1/bootstrap --keyring-backend=test keys list
- name: ag-solo
  type: local
  address: agoric1tse8uawf2pqmamjafyzjye5t2tsxezg0004d4y
  pubkey: agoricpub1addwnpepqg9nysgmq4hq6a6vaka44lw2x9y98ywvkvq826s5c9uqrpfxljr36ph35dg
  mnemonic: ""
  threshold: 0
  pubkeys: []
- name: bootstrap
  type: local
  address: agoric1f32juj9y6scmkmxykw5cah2yff9vrkp77w6rzy
  pubkey: agoricpub1addwnpepq0qldzwu62z8ezeu0ugatq8mctpt4gplkum05w4qh0jqh9kteuyy5wcqt8n
  mnemonic: ""
  threshold: 0
  pubkeys: []

soil:cosmic-swingset michael$

but:


@michaelfig
Copy link
Contributor

Works for me!

@alexanderbez alexanderbez added A:automerge Automatically merge PR once all prerequisites pass. C:Keys Keybase, KMS and HSMs labels Oct 8, 2020
@alexanderbez alexanderbez merged commit f3733aa into master Oct 8, 2020
@alexanderbez alexanderbez deleted the bez/keyring-dir-flag branch October 8, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants