Refactor x/{gov, crisis} according to ADR 031 #7533

atheeshp · 2020-10-14T10:01:54Z

Description

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

codecov · 2020-10-14T10:07:56Z

Codecov Report

Merging #7533 into master will decrease coverage by 0.17%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##           master    #7533      +/-   ##
==========================================
- Coverage   54.77%   54.59%   -0.18%     
==========================================
  Files         601      603       +2     
  Lines       38142    38151       +9     
==========================================
- Hits        20891    20828      -63     
- Misses      15126    15204      +78     
+ Partials     2125     2119       -6

…00-x-gov

x/gov/handler.go

proto/cosmos/crisis/v1beta1/tx.proto

…00-x-gov

…o atheesh/7500-x-gov

amaury1093

lgtm 👍

* Refactor x/gov according to ADR 31 * fix tests * Refactor x/crisis according to ADR 031 * fix lint * lint * lint * review changes * lint * review change * fic doc Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Refactor RegisterQueryServices -> RegisterServices (#7518) * Refactor RegisterQueryServices -> RegisterServices * Fix tests * Add ADR 031 BaseApp and codec infrastructure (#7519) * Refactor RegisterQueryServices -> RegisterServices * Cleaner proto files * Fix tests * Add MsgServer * Fix lint * Remove MsgServer from configurator for now * Remove useless file * Fix build * typo * Add router * Fix test * WIP * Add router * Remove test helper * Add beginning of test * Move test to simapp? * ServiceMsg implement sdk.Msg * Add handler by MsgServiceRouter * Correct signature * Add full test * use TxEncoder * Update baseapp/msg_service_router.go Co-authored-by: Aaron Craelius <aaron@regen.network> * Push changes * WIP on ServiceMsg unpacking * Make TestMsgService test pass * Fix tests * Tidying up * Tidying up * Tidying up * Add JSON test * Add comments * Tidying * Lint * Register MsgRequest interface * Rename * Fix tests * RegisterCustomTypeURL * Add changelog entries * Put in features * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Address review comments * Address nit * Fix lint * Update codec/types/interface_registry.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * godoc Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Refactor x/bank according to ADR 031 (#7520) * Refactor x/bank according to ADR 031 * Add comment * Update comment * Add comment * Add tests, address edge cases * Imports Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/{gov, crisis} according to ADR 031 (#7533) * Refactor x/gov according to ADR 31 * fix tests * Refactor x/crisis according to ADR 031 * fix lint * lint * lint * review changes * lint * review change * fic doc Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/distribution according to ADR 031 (#7524) * Refactor x/distribution according to ADR 31 * lint * removed unused * Apply suggestions from code review Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * [x/slashing] Implement Protobuf Msg Services (#7557) * Update x/slashing to use proto msg service * Fix proto-gen Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/auth/vesting to use ADR-031 (#7551) * update auth/vesting module to use proto msg services * rm accidental tmp files * Update x/auth/vesting/msg_server.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * golangci-lint fix Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/staking according to ADR 031 (#7556) * Refactor x/staking according to ADR 031 * lint * review changes * review changes * review changes Co-authored-by: Aaron Craelius <aaron@regen.network> * Add MsgServer to Configurator for ADR 031 wiring (#7584) * Add MsgServer to Configurator for ADR 031 wiring * Add docs, wire up evidence & staking * Add integration test * Add comments * Doc strings * Update types/module/configurator.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update types/module/configurator.go Co-authored-by: Cory <cjlevinson@gmail.com> * Wire up vesting * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Cory <cjlevinson@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/evidence to ADR-031 (#7538) * Refactor x/evidence to ADR-031 * Add hash in response * Update changelog * Update x/evidence/keeper/keeper.go * Update proto/cosmos/evidence/v1beta1/tx.proto Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Use msgServer struct Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Refactor x/ibc to ADR 031 (#7576) * WIP: Refactor x/ibc to ADR 031 * updated handler * removed unsued * fix * Add proto service for ibc/transfer * lint * remove old upgrade handler * added doc * review changes * fix tests * formatter * Add MsgServer wiring in RegisterServices Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * add changelog entries for non-nil Result.Data fields in message responses Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>

Refactor x/gov according to ADR 31

1d70609

fix tests

47874c6

amaury1093 mentioned this pull request Oct 14, 2020

Implement ADR 031: Protobuf Msg Services #7500

Closed

16 tasks

atheeshp added 2 commits October 14, 2020 19:23

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/75…

444adc3

…00-x-gov

Refactor x/crisis according to ADR 031

13e6314

atheeshp changed the title ~~Refactor x/gov according to ADR 031~~ Refactor x/{gov, crisis} according to ADR 031 Oct 14, 2020

atheeshp added 3 commits October 14, 2020 19:45

fix lint

90d1bd5

lint

73fc24d

lint

af3fe78

clevinson linked an issue Oct 14, 2020 that may be closed by this pull request

[x/gov & x/crisis] Implement Protobuf Msg Services #7544

Closed

aaronc added this to the v0.41 milestone Oct 14, 2020

Merge branch 'master' into atheesh/7500-x-gov

4440e95

atheeshp marked this pull request as ready for review October 15, 2020 12:35

atheeshp requested review from aaronc, alessio and alexanderbez as code owners October 15, 2020 12:35

atheeshp requested review from anilcse, clevinson, aleem1314, amaury1093, blushi and robert-zaremba October 15, 2020 12:36

blushi reviewed Oct 15, 2020

View reviewed changes

x/gov/handler.go Outdated Show resolved Hide resolved

aaronc reviewed Oct 15, 2020

View reviewed changes

x/gov/handler.go Outdated Show resolved Hide resolved

aaronc added C:x/crisis C:x/gov labels Oct 15, 2020

robert-zaremba reviewed Oct 15, 2020

View reviewed changes

proto/cosmos/crisis/v1beta1/tx.proto Show resolved Hide resolved

atheeshp added 2 commits October 16, 2020 12:13

review changes

9323b6d

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/75…

7def92c

…00-x-gov

Merge branch 'atheesh/7500-x-gov' of github.com:cosmos/cosmos-sdk int…

ef0c89f

…o atheesh/7500-x-gov

atheeshp requested review from aaronc and blushi October 16, 2020 06:45

atheeshp added 3 commits October 16, 2020 12:30

lint

6409288

review change

3df2a04

fic doc

9bdb69a

blushi approved these changes Oct 16, 2020

View reviewed changes

amaury1093 approved these changes Oct 16, 2020

View reviewed changes

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 16, 2020

mergify bot added 3 commits October 16, 2020 09:47

Merge branch 'master' into atheesh/7500-x-gov

8d44bb8

Merge branch 'master' into atheesh/7500-x-gov

f3b66b1

Merge branch 'master' into atheesh/7500-x-gov

b11edbd

mergify bot merged commit 6e569e1 into master Oct 16, 2020

mergify bot deleted the atheesh/7500-x-gov branch October 16, 2020 13:04

clevinson mentioned this pull request Oct 19, 2020

Implement Protobuf Msg Services #7540

Closed

16 tasks

clevinson mentioned this pull request Oct 19, 2020

[backport/v0.40.x] Implement ADR031 #7599

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor x/{gov, crisis} according to ADR 031 #7533

Refactor x/{gov, crisis} according to ADR 031 #7533

atheeshp commented Oct 14, 2020 •

edited by aaronc

Loading

codecov bot commented Oct 14, 2020 •

edited

Loading

amaury1093 left a comment

Refactor x/{gov, crisis} according to ADR 031 #7533

Refactor x/{gov, crisis} according to ADR 031 #7533

Conversation

atheeshp commented Oct 14, 2020 • edited by aaronc Loading

Description

codecov bot commented Oct 14, 2020 • edited Loading

Codecov Report

amaury1093 left a comment

Choose a reason for hiding this comment

atheeshp commented Oct 14, 2020 •

edited by aaronc

Loading

codecov bot commented Oct 14, 2020 •

edited

Loading