-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate tx commands for auth #7788
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7788 +/- ##
==========================================
+ Coverage 54.19% 54.20% +0.01%
==========================================
Files 610 609 -1
Lines 38872 38859 -13
==========================================
Hits 21065 21065
+ Misses 15650 15637 -13
Partials 2157 2157 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm 👍 Would like to see a changelog entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK'd - pending @amaurymartiny's comments
Description
This removes auth tx sub commands from
simd tx
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes