enrich versioning with build deps #7848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 8, 2020 02:26
It's command's objective to actually display versioning information.
Codecov Report
@@ Coverage Diff @@
## master #7848 +/- ##
==========================================
- Coverage 54.23% 54.23% -0.01%
==========================================
Files 609 609
Lines 38807 38817 +10
==========================================
+ Hits 21046 21051 +5
- Misses 15604 15609 +5
Partials 2157 2157 |
alessio
requested review from
fedekunze,
jackzampolin,
jgimeno and
sahith-narahari
|
A practical example follows. This is the information presently displayed by The following is |
amaury1093
approved these changes
Nov 9, 2020
|
@amaurymartiny yep: #7835 Plus I bet users would find extremely useful while debugging to know what version of the cosmos-sdk their app builds on. |
alexanderbez
approved these changes
Nov 9, 2020
9 tasks
alessio
pushed a commit
that referenced
this pull request
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version command now displays the list of
build dependencies.
Also fix version's command output stream.
version's output should go to stdout as it's the command's
objective to actually display versioning information.
closes: #7835
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes