Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mismatched solomachine signature data type verification #7882

Merged
merged 4 commits into from
Nov 10, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Nov 10, 2020

Description

Addresses part 2 of the referenced issue

ref: #7823


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #7882 (7c9dfd7) into master (300b739) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7882   +/-   ##
=======================================
  Coverage   54.19%   54.20%           
=======================================
  Files         610      610           
  Lines       38846    38847    +1     
=======================================
+ Hits        21053    21056    +3     
+ Misses      15638    15636    -2     
  Partials     2155     2155           

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - thanks!

@cwgoes cwgoes added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 10, 2020
@mergify mergify bot merged commit 0bd4657 into master Nov 10, 2020
@mergify mergify bot deleted the colin/7823-sm-fixes branch November 10, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants