Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC Upgrades function interface return client/consensus #7895

Merged
merged 3 commits into from
Nov 11, 2020

Conversation

colin-axner
Copy link
Contributor

Description

closes: #7876
closes: #7878


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #7895 (1ef555e) into master (76ffdcc) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #7895   +/-   ##
=======================================
  Coverage   54.18%   54.18%           
=======================================
  Files         612      612           
  Lines       38960    38958    -2     
=======================================
+ Hits        21109    21110    +1     
+ Misses      15692    15690    -2     
+ Partials     2159     2158    -1     

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start, seems like it makes the most sense to get this merged and I can take over integrating consensus states? What are your thoughts @colin-axner ?

@colin-axner
Copy link
Contributor Author

Looks like a good start, seems like it makes the most sense to get this merged and I can take over integrating consensus states? What are your thoughts @colin-axner ?

Those were my exact thoughts 👍

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 11, 2020
@mergify mergify bot merged commit e9f1922 into master Nov 11, 2020
@mergify mergify bot deleted the colin/7876-verifyupgrade-interface branch November 11, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
3 participants