Fix power reduction test cast int64 #7897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date CreateValidator, CreateValidatorMsg, Delegate helper functions to fix int64 overflow
…onsensusPower to consider PowerReduction
antstalepresh
requested review from
aaronc,
alessio and
alexanderbez
as code owners
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
Why do we need these init calls? Isn't sdk.PowerReduction already set to this value?
There was a problem hiding this comment.
For staking, we want to test it in PowerReduction = 10^18, to check overflow cases. cc. @sunnya97
There was a problem hiding this comment.
PowerReduction is set to 10^6 by default.
But we want to run the tests with a PowerReduction of 10^18, in order to make sure they work with a value that would overflow an int64.
| float32(a.Amount.Int64()), | ||
| []metrics.Label{telemetry.NewLabel("denom", a.Denom)}, | ||
| ) | ||
| if a.Amount.IsInt64() { |
There was a problem hiding this comment.
Thank you for fixing all of these 🙏
…reduction_test_cast_int64
Codecov Report
@@ Coverage Diff @@
## master #7897 +/- ##
==========================================
- Coverage 54.15% 54.14% -0.01%
==========================================
Files 612 612
Lines 39023 39029 +6
==========================================
Hits 21134 21134
- Misses 15714 15720 +6
Partials 2175 2175 |
9 tasks
alexanderbez
approved these changes
Nov 11, 2020
robert-zaremba
approved these changes
Nov 13, 2020
alessio
approved these changes
Nov 13, 2020
amaury1093
added
the
A:automerge
|
@antstalepresh please merge master in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resolves testing issues on PowerReduction change
closes: #7655
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes