Minor fixes for ibc tendermint #7916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
colin-axner
commented
Nov 12, 2020
| @@ -40,6 +42,13 @@ func (cs ClientState) VerifyUpgradeAndUpdateState( | |||
| cs.GetLatestHeight().GetVersionNumber(), upgradeHeight.GetVersionNumber()) | |||
| } | |||
|
|
|||
| // UpgradeHeight must be greater than or equal to current client state height | |||
| if cs.GetLatestHeight().GetVersionHeight() > upgradeHeight.GetVersionHeight() { | |||
There was a problem hiding this comment.
I wasn't sure if they could be equal but it sounds logical to me that the latest client state must be less than or equal to the upgrade height?
Codecov Report
@@ Coverage Diff @@
## master #7916 +/- ##
==========================================
- Coverage 54.17% 54.15% -0.02%
==========================================
Files 612 612
Lines 38989 38985 -4
==========================================
- Hits 21122 21114 -8
- Misses 15698 15701 +3
- Partials 2169 2170 +1 |
fedekunze
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7879
closes: #7880
closes: #7863
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes