Update transfer docs and make ibc prefix a const #7926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
colin-axner
commented
Nov 13, 2020
| @@ -25,6 +25,9 @@ const ( | |||
|
|
|||
| // QuerierRoute is the querier route for IBC transfer | |||
| QuerierRoute = ModuleName | |||
|
|
|||
| // DenomPrefix is the prefix used for internal SDK coin representation. | |||
| DenomPrefix = "ibc" | |||
There was a problem hiding this comment.
should this be a var? I think the difference would be whether we want to allow an application creator to choose their own prefix
There was a problem hiding this comment.
yeah, I think it makes sense?
There was a problem hiding this comment.
Actually, lets just leave as a const, if it is a var another module could simply change the value of the prefix which we can't allow for safety
Codecov Report
@@ Coverage Diff @@
## master #7926 +/- ##
=======================================
Coverage 54.17% 54.17%
=======================================
Files 612 612
Lines 38999 38999
=======================================
Hits 21129 21129
Misses 15697 15697
Partials 2173 2173 |
AdityaSripal
approved these changes
Nov 13, 2020
fedekunze
approved these changes
Nov 13, 2020
colin-axner
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7906
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes