Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection path validation and remove unused PathValidator function #7930

Merged
merged 4 commits into from
Nov 16, 2020

Conversation

colin-axner
Copy link
Contributor

Description

Not a big issue since from what I can tell we only store this to make queries easier

closes: #7927


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #7930 (d83b4c6) into master (6b62d26) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7930      +/-   ##
==========================================
- Coverage   54.17%   54.17%   -0.01%     
==========================================
  Files         612      612              
  Lines       38997    38994       -3     
==========================================
- Hits        21128    21125       -3     
  Misses      15697    15697              
  Partials     2172     2172              

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 13, 2020
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit cd29fd6 into master Nov 16, 2020
@mergify mergify bot deleted the colin/7927-connection-id-validation branch November 16, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use connection id validation instead of PathValidator on client connection paths
3 participants