-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version --long displays replaced build dependencies #7941
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanjukim
requested review from
aaronc,
alessio and
alexanderbez
as code owners
November 16, 2020 04:00
hanjukim
changed the title
version --long displays replaced modules
version --long displays replaced build dependencies
Nov 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #7941 +/- ##
==========================================
- Coverage 54.17% 54.17% -0.01%
==========================================
Files 612 612
Lines 38994 38996 +2
==========================================
Hits 21125 21125
- Misses 15697 15699 +2
Partials 2172 2172 |
alessio
reviewed
Nov 16, 2020
alessio
reviewed
Nov 16, 2020
alessio
approved these changes
Nov 16, 2020
alessio
reviewed
Nov 16, 2020
alessio
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Nov 16, 2020
fdymylja
approved these changes
Nov 16, 2020
alessio
pushed a commit
that referenced
this pull request
Nov 16, 2020
9 tasks
clevinson
pushed a commit
that referenced
this pull request
Nov 19, 2020
From: #7941 Co-authored-by: Paul Kim <hanjukim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The version command now displays replaced modules in build dependencies
closes: #7940
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes