update transfer error messages #7968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
colin-axner
changed the title
AdityaSripal
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Looks fine to me. Would like review from @cwgoes as well to make sure we never panic when we shouldn't
| // counterparty module. The bug may occur in bank or any part of the code that allows | ||
| // the escrow address to be drained. A malicious counterparty module could drain the | ||
| // escrow address by allowing more tokens to be sent back then were escrowed. | ||
| return sdkerrors.Wrap(err, "unable to unescrow tokens, this may be caused by a malicious counterparty module or a bug: please open an issue") |
There was a problem hiding this comment.
Suggested change
| return sdkerrors.Wrap(err, "unable to unescrow tokens, this may be caused by a malicious counterparty module or a bug: please open an issue") | |
| return sdkerrors.Wrap(err, "unable to unescrow tokens, this may be caused by a malicious counterparty module or a bug: please open an issue on counterparty module") |
Don't necessarily want this going to SDK first, since first check is bug in the module/malicous party
There was a problem hiding this comment.
added to both error messages
Codecov Report
@@ Coverage Diff @@
## master #7968 +/- ##
==========================================
- Coverage 54.17% 54.17% -0.01%
==========================================
Files 612 612
Lines 39047 39051 +4
==========================================
+ Hits 21153 21155 +2
- Misses 15719 15720 +1
- Partials 2175 2176 +1 |
cwgoes
approved these changes
Nov 18, 2020
fedekunze
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changes inspired by:
and discussion with @AdityaSripal
ref: #7736
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes