client/keys: print out pubkeys in JSON format #808
Conversation
Add flag to the show command to print out public keys in JSON format. See tendermint/go-crypto#79 for more information.
Codecov Report
@@ Coverage Diff @@
## develop #808 +/- ##
========================================
Coverage 65.26% 65.26%
========================================
Files 65 65
Lines 3524 3524
========================================
Hits 2300 2300
Misses 1041 1041
Partials 183 183 |
| @@ -30,16 +39,20 @@ func getKey(name string) (keys.Info, error) { | |||
| // CMD | |||
|
|
|||
| func runShowCmd(cmd *cobra.Command, args []string) error { | |||
| if len(args) != 1 || len(args[0]) == 0 { | |||
| return errors.New("You must provide a name for the key") | |||
| info, err := getKey(args[0]) | |||
There was a problem hiding this comment.
We should still check the length of args and print a helpful error if it isn't equal to 1.
There was a problem hiding this comment.
See github.com/spf13/cobra.ExactArgs()
| ) | ||
|
|
||
| var showKeysCmd = &cobra.Command{ | ||
| Use: "show <name>", | ||
| Short: "Show key info for the given name", | ||
| Long: `Return public details of one local key.`, | ||
| RunE: runShowCmd, | ||
| Args: cobra.ExactArgs(1), |
There was a problem hiding this comment.
@cwgoes nope, this just does it
| if err != nil { | ||
| return err | ||
| } | ||
| fmt.Println(string(out)) |
There was a problem hiding this comment.
I don't like the idea of moving out of the current process train of printing everything through the printInfo function (right below this comment)...
Also don't like introducing another key. Already you can get the pubkey in json by using gaiacli keys show <yourkey> --output json - If you want to also see the pubkey with "text" output (aka --output text aka the default) then we should add that right about here:
cosmos-sdk/client/keys/utils.go
Line 58 in 18ac0f9
maybe with a table header so it would look like:
name address pubkey
alessio 197609375... 0x1241412....
just need to make sure we'd get it right for keys list as well as keys show but meh - I'm okay with just using --output json myself
There was a problem hiding this comment.
Hi!
Apologies for the late reply.
Already you can get the pubkey in json by using gaiacli keys show --output json
True, but the following prints the private key out too:
alessio@bizet:~/.../github.com/tendermint/clearchain$ clearchainctl keys show --output json ch_admin_1
{"name":"ch_admin_1","pubkey":[1,"CEB016A0495DEE269D655F12DE14941963214B3BEE034C3DDFDBCECB2627D3C7"],"privkey.armor":"-----BEGIN TENDERMINT PRIVATE KEY-----\nkdf: bcrypt\nsalt: CB69DDE1B83E179E7DED2C9A7FDE1BA8\n\n3Q2YAte6PArOEnMt9YR5CNmAyk7H6cFvZLuibwxoIlf+B7whJ8Xj4TZmBDo/JfEE\nlcdUZTafvGvHp2vxZ7PVg0ria+sJIPqQlgaNI1iGXqZ/kRYHSuRPIKwniRwrk6LE\nXFE5c8DN3Ceu\n=v8dc\n-----END TENDERMINT PRIVATE KEY-----"}
Furthermore, the public key JSON format seems a bit fuzzy: [1,"CEB016A0495DEE269D655F12DE14941963214B3BEE034C3DDFDBCECB2627D3C7"]
If you want to also see the pubkey with "text" output (aka --output text aka the default) then we should add that right about here: [snip]
That's fair, I'd be happy with that too! I just need to allow users to exchange public keys in a portable format, be it a string or a JSON thing.
There was a problem hiding this comment.
So it sounds like we just want to improve the JSON output format, which I could totally get behind - maybe don't print the private key by default too
There was a problem hiding this comment.
Okay yeah the validator json key is not a HEX string which stinks
|
Closed in favour of #886 |
…osmos#808) * fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955) * use directly instead of cast --------- Co-authored-by: Antonio Pitasi <antonio@pitasi.dev>
…osmos#808) * fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955) * use directly instead of cast --------- Co-authored-by: Antonio Pitasi <antonio@pitasi.dev>
* feat(x/tx): support bytes field as signer (cosmos#21850) * Problem: multisig account failed on threshold encode after send tx (cosmos#808) * fix(x/tx): don't shadow Amino marshalling error messages (cosmos#19955) * use directly instead of cast --------- Co-authored-by: Antonio Pitasi <antonio@pitasi.dev> * feat: Fix datarace --------- Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Antonio Pitasi <antonio@pitasi.dev>
No description provided.