-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase ibc basic genesis validation #8081
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
aa7c0be
increase client basic genesis validation
colin-axner 464a4fa
add connection/channel genesis validation
colin-axner 26513d0
Merge branch 'master' into colin/8073-ibc-init-gen-validation
colin-axner 93e7edb
fix tests
colin-axner 4147b7e
apply @AdityaSripal suggestion
colin-axner dd772cc
Merge branch 'master' into colin/8073-ibc-init-gen-validation
colin-axner ca916de
Merge branch 'master' into colin/8073-ibc-init-gen-validation
cwgoes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be checking that if
maxSequence == 0
thengs.NextClientSequence == 0
as well?And should we check that if
maxSequence != 0
, thengs.NextClientSequence == maxSequence + 1
?Or no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to put such strict restrictions on this. I think there is value in allowing the next client sequence to be very different from the maximum sequence. For example, if during a genesis migration, validators decide to prune old expired clients. Or if genesis validators decide to create clients using identifiers in genesis from 0-900 and start regular clients at 1000 to distinguish their origins