Generic 02-client cli cmds, removes light client specific ones #8259
Conversation
There was a problem hiding this comment.
I'm getting the error
cannot unpack Any into ClientState *types.Any: failed unpacking protobuf message from Any
I think because the cache is not populating after unmarshaling an Any with JSON. I've come across this before. Is there any way to get the cache to populate?
| @@ -480,10 +480,16 @@ func (s *IntegrationTestSuite) testQueryIBCTx(txRes sdk.TxResponse, cmd *cobra.C | |||
| func (s *IntegrationTestSuite) TestLegacyRestErrMessages() { | |||
| val := s.network.Validators[0] | |||
|
|
|||
| // Write client state json to temp file, used for an IBC message. | |||
| clientStateJSON := testutil.WriteToNewTempFile( | |||
There was a problem hiding this comment.
changing this since the cli command is being moved to a more generic one
|
|
||
| clientState := types.NewClientState(sequence, consensusState, allowUpdateAfterProposal) | ||
| msg, err := clienttypes.NewMsgCreateClient(clientState, consensusState, clientCtx.GetFromAddress()) | ||
| msg, err := types.NewMsgCreateClient(clientState, consensusState, clientCtx.GetFromAddress()) |
There was a problem hiding this comment.
Note: I intentionally do not return the client identifier generated since the call below is GenerateOrBroadcastTx. This code cannot return a client identifier if the transaction is simply generated and not broadcasted. If users want this functionality, they should use external resources like a relayer. This should really only be for testing
Codecov Report
@@ Coverage Diff @@
## master #8259 +/- ##
==========================================
- Coverage 61.91% 61.91% -0.01%
==========================================
Files 609 609
Lines 35100 35101 +1
==========================================
Hits 21732 21732
- Misses 11084 11085 +1
Partials 2284 2284
|
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
| NewCreateClientCmd(), | ||
| NewUpdateClientCmd(), | ||
| NewSubmitMisbehaviourCmd(), |
There was a problem hiding this comment.
What about update proposal and upgrade client?
There was a problem hiding this comment.
I will add update client after the change to update client handling. The proposed approach would only require submitting a client identifier which is a lot less code than taking in a header
There was a problem hiding this comment.
proposals are included on the gov CLI afaik
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| clientCtx = clientCtx.WithHeight(height) |
There was a problem hiding this comment.
Why is this no longer needed?
There was a problem hiding this comment.
PrintProto doesn't print the context height. This code was likely introduced after confusion of looking at the previously existing rest code. The helper function for rest returns rest responses with the height injected into the response based on the context height. Since queries of a context height of 0 use the latest height, this was a necessary step to returning the correct height
colin-axner
added
the
A:automerge
Description
closes: #7874
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes