Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/tendermint/tendermint from 0.34.4 to 0.34.7 #8618

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 18, 2021

Bumps github.com/tendermint/tendermint from 0.34.4 to 0.34.7.

Release notes

Sourced from github.com/tendermint/tendermint's releases.

0.34.7 (WARNING: BETA SOFTWARE)

https://github.com/tendermint/tendermint/blob/v0.34.7/CHANGELOG.md#v0.34.7

Changelog

Sourced from github.com/tendermint/tendermint's changelog.

v0.34.7

February 18, 2021

This release fixes a downstream security issue which impacts Cosmos SDK users who are:

  • Using Cosmos SDK v0.40.0 or later, AND
  • Running validator nodes, AND
  • Using the file-based FilePV implementation for their consensus keys

Users who fulfill all the above criteria were susceptible to leaking private key material in the logs. All other users are unaffected.

The root cause was a discrepancy between the Tendermint Core (untyped) logger and the Cosmos SDK (typed) logger: Tendermint Core's logger automatically stringifies Go interfaces whenever possible; however, the Cosmos SDK's logger uses reflection to log the fields within a Go interface.

The introduction of the typed logger meant that previously un-logged fields within interfaces are now sometimes logged, including the private key material inside the FilePV struct.

Tendermint Core v0.34.7 fixes this issue; however, we strongly recommend that all validators use remote signer implementations instead of FilePV in production.

Thank you to @joe-bowman for his assistance with this vulnerability and a particular shout-out to @marbar3778 for diagnosing it quickly.

Friendly reminder: We have a bug bounty program.

BUG FIXES

  • [consensus] #6128 Remove privValidator from log call (@tessr)

v0.34.6

February 18, 2021

Tendermint Core v0.34.5 and v0.34.6 have been recalled due to build tooling problems.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file labels Feb 18, 2021
@dependabot dependabot bot requested a review from fedekunze February 18, 2021 05:43
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 18, 2021

Looks like github.com/tendermint/tendermint is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Feb 18, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/tendermint/tendermint-0.34.7 branch February 18, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants