-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bank]: add balance tracking events #8656
Conversation
…/cosmos/cosmos-sdk into fdymylja/balance-tracking-events
Codecov Report
@@ Coverage Diff @@
## master #8656 +/- ##
==========================================
- Coverage 61.37% 61.36% -0.02%
==========================================
Files 670 671 +1
Lines 38286 38324 +38
==========================================
+ Hits 23499 23516 +17
- Misses 12329 12350 +21
Partials 2458 2458
|
…acking-events # Conflicts: # x/bank/keeper/migrations.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Can you amend the spec/events file to contain the new events.
were you able to test this locally on a network?
@marbar3778 I don't think we tested it already on a @fdymylja I think there are a few linter warnings that should be fixed |
…/cosmos/cosmos-sdk into fdymylja/balance-tracking-events
on it
tested locally, works for begin block, endblock events and normal txs with one or multiple messages (even when balance changes happen during ante handlers execution) |
I've addressed the requested changes, please let me know if you feel there is anything else that needs to be adjusted |
thank you! looks good to me. Would be nice to test locally or on a server but shouldnt be a blocker |
FTR @marbar3778 @fdymylja testing happens here:
|
Description
This PR includes a state breaking change in events.
Specifically, there's the introduction of four new events which serve the purpose of tracking balance and supply changes.
These events allow for full balance and supply tracking in the sdk, both in deliver tx, begin and endblock.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes