server: fix interceptConfigs (bp #8641) #8659
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* server: fix interceptConfigs * cl++ * revert call * update error message * revise TestInterceptConfigsPreRunHandlerDoesNotMixConfigFiles * remove TestInterceptConfigsPreRunHandlerDoesNotMixConfigFiles Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 2f069c9) # Conflicts: # CHANGELOG.md # server/util.go
mergify
bot
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## release/v0.41.x #8659 +/- ##
===================================================
- Coverage 61.93% 61.92% -0.01%
===================================================
Files 611 611
Lines 35250 35246 -4
===================================================
- Hits 21831 21827 -4
Misses 11136 11136
Partials 2283 2283
|
|
This pull request introduces 9 alerts when merging a696436 into 128cb54 - view on LGTM.com new alerts:
|
| @@ -44,7 +44,16 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ### Improvements | |||
There was a problem hiding this comment.
@alessio there is no pending section in this file for the next 0.41 release. Where do these entries go?
There was a problem hiding this comment.
yeah I'm about to open a PR for that
There was a problem hiding this comment.
@alexanderbez for now just don't add an entry. I think it's much easier to prep and finalize both changelog and release notes at release time. So we do the work only once. Wdyt?
There was a problem hiding this comment.
I agree. But the changelog entries need to be tracked somewhere, right? How does the release manager know what to add?
There was a problem hiding this comment.
There you go: https://github.com/cosmos/cosmos-sdk/milestone/40
There was a problem hiding this comment.
All merged PRs must be included in the release milestone
This is an automatic backport of pull request #8641 done by Mergify.
Cherry-pick of 2f069c9 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/