bank: name and symbol metadata fields #8677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
aaronc,
alessio and
alexanderbez
as code owners
alessio
approved these changes
Feb 23, 2021
fedekunze
added
the
A:automerge
fedekunze
commented
Feb 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #8677 +/- ##
=======================================
Coverage 61.48% 61.49%
=======================================
Files 659 659
Lines 38045 38049 +4
=======================================
+ Hits 23393 23399 +6
+ Misses 12193 12192 -1
+ Partials 2459 2458 -1
|
amaury1093
reviewed
Feb 24, 2021
| string name = 5; | ||
| // symbol is the token symbol usually shown on exchanges (eg: ATOM). This can | ||
| // be the same as the display. | ||
| string symbol = 6; |
There was a problem hiding this comment.
Do we really need symbol? Can you give an example where symbol is not display upper/lower-cased?
There was a problem hiding this comment.
@jtremback thoughts here? I'm fine with either tbh
There was a problem hiding this comment.
BTC vs Bitcoin, ETH vs Ether, etc.
This was referenced Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8614
cc: @jtremback