Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning notice in changelog for v0.41.x bug (ref: #8461) #8707

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Add warning notice in changelog for v0.41.x bug (ref: #8461) #8707

merged 4 commits into from
Feb 26, 2021

Conversation

clevinson
Copy link
Contributor

@clevinson clevinson commented Feb 25, 2021 •
edited
Loading

Description

Adds a notice in changelog warning non-hub Cosmos SDK based chains to not use the v0.41.x series due to bug in evidence's usage of bech32 prefixes (#8461).

This has also been added to github release notes here.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

tac0turtle
tac0turtle reviewed Feb 25, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@clevinson clevinson added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 25, 2021
@clevinson clevinson merged commit b19ac2c into master Feb 26, 2021
@clevinson clevinson deleted the clevinson/update-0.41-warning branch February 26, 2021 00:48
mergify bot pushed a commit that referenced this pull request Feb 26, 2021
@clevinson
Add warning notice in changelog for v0.41.x bug (ref: #8461) (#8707)
13844c7 
* add disclaimer for v0.41 series for non-hub SDK chains due to #8461

* update issue link

* update issue link, pt2

* fix bad issue link

(cherry picked from commit b19ac2c)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Feb 26, 2021
Merged
alessio pushed a commit that referenced this pull request Feb 26, 2021
@mergify @clevinson
Add warning notice in changelog for v0.41.x bug (ref: #8461) (bp #8707)…
50744f8 
… (#8708)

* Add warning notice in changelog for v0.41.x bug (ref: #8461) (#8707)

* add disclaimer for v0.41 series for non-hub SDK chains due to #8461

(cherry picked from commit b19ac2c)

Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
This was referenced Apr 13, 2023
Open
Open
Open
This was referenced Aug 24, 2023
Closed
Closed
Closed
This was referenced Feb 7, 2024
Closed
Closed
Closed
@neutron-robot neutron-robot mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clevinson @tac0turtle