Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: allow 0 coin accounts in genesis #8714

Merged
merged 4 commits into from
Feb 26, 2021
Merged

auth: allow 0 coin accounts in genesis #8714

merged 4 commits into from
Feb 26, 2021

Conversation

tac0turtle
Copy link
Member

Description

allow accounts to have a balance of 0 in genesis

closes: #8626

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tac0turtle tac0turtle marked this pull request as ready for review February 26, 2021 15:02
@alessio
Copy link
Contributor

alessio commented Feb 26, 2021

Looks good to me! @marbar3778 did you test it with simd too?

@tac0turtle
Copy link
Member Author

tac0turtle commented Feb 26, 2021 •
edited
Loading

Looks good to me! @marbar3778 did you test it with simd too?

yes, tested on the hub as well

❯ gaiad validate-genesis
File at /Users/markobaricevic/.gaia/config/genesis.json is a valid genesis file

fdymylja
fdymylja approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sahith-narahari
sahith-narahari approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@sahith-narahari sahith-narahari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alessio alessio added A:automerge Automatically merge PR once all prerequisites pass. backport/0.41.x (Stargate) labels Feb 26, 2021
@mergify mergify bot merged commit a786830 into master Feb 26, 2021
@mergify mergify bot deleted the 8626-0-accounts branch February 26, 2021 15:41
mergify bot pushed a commit that referenced this pull request Feb 26, 2021
@tac0turtle
auth: allow 0 coin accounts in genesis (#8714)
d31fc83 
* allow zero accounts

* fix test

* fix test

(cherry picked from commit a786830)

# Conflicts:
#	x/bank/types/genesis_test.go
@mergify mergify bot mentioned this pull request Feb 26, 2021
Merged
alessio pushed a commit that referenced this pull request Feb 26, 2021
@mergify @tac0turtle
auth: allow 0 coin accounts in genesis (bp #8714) (#8716)
16fbb50 
* auth: allow 0 coin accounts in genesis (#8714)

* allow zero accounts

* fix test

* fix test

(cherry picked from commit a786830)

Co-authored-by: Marko <marbar3778@yahoo.com>
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdymylja fdymylja fdymylja approved these changes

@sahith-narahari sahith-narahari sahith-narahari approved these changes

@anilcse anilcse anilcse approved these changes

@alessio alessio alessio approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@jgimeno jgimeno Awaiting requested review from jgimeno

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow empty accounts in validate-genesis
5 participants
@tac0turtle @alessio @anilcse @sahith-narahari @fdymylja