Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport KVCache speeds ups to launchpad. #8723

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Backport KVCache speeds ups to launchpad. #8723

merged 3 commits into from
Mar 1, 2021

Conversation

zmanian
Copy link
Member

@zmanian zmanian commented Feb 27, 2021

Backports the KVCache optimizations from #8719 to launchpad.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@odeke-em @zmanian
store/cachekv, x/bank/types: algorithmically fix pathologically slow …
31942a1 
…code (#8719)

After continuously profiling InitGensis with 100K accounts, it showed
pathologically slow code, that was the result of a couple of patterns:
* Unconditional and not always necessary map lookups
* O(n^2) sdk.AccAddressFromBech32 retrievals when the code is expensive,
during a quicksort

The remedy involved 4 parts:
* O(n) sdk.AccAddressFromBech32 invocations, down from O(n^2) in the quicksort
* Only doing map lookups when the domain key check has passed
* Using a black magic compiler technique of the map clearing idiom
* Zero allocation []byte<->string conversion

With 100K accounts, this brings InitGenesis down to ~6min, instead of
20+min, it reduces the sort code from ~7sec down to 50ms.

Also some simple benchmark reflect the change:
```shell
name                    old time/op    new time/op    delta
SanitizeBalances500-8     19.3ms ±10%     1.5ms ± 5%  -92.46%  (p=0.000 n=20+20)
SanitizeBalances1000-8    41.9ms ± 8%     3.0ms ±12%  -92.92%  (p=0.000 n=20+20)

name                    old alloc/op   new alloc/op   delta
SanitizeBalances500-8     9.05MB ± 6%    0.56MB ± 0%  -93.76%  (p=0.000 n=20+18)
SanitizeBalances1000-8    20.2MB ± 3%     1.1MB ± 0%  -94.37%  (p=0.000 n=20+19)

name                    old allocs/op  new allocs/op  delta
SanitizeBalances500-8      72.4k ± 6%      4.5k ± 0%  -93.76%  (p=0.000 n=20+20)
SanitizeBalances1000-8      162k ± 3%        9k ± 0%  -94.40%  (p=0.000 n=20+20)
```

The CPU profiles show the radical change as per
#7766 (comment)

Later on, we shall do more profiling and fixes but for now this brings
down the run-time for InitGenesis.

Fixes #7766

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
@zmanian zmanian changed the title store/cachekv, x/bank/types: algorithmically fix pathologically slow code (#8719) Backport KVCache speeds ups to launchpad. Feb 27, 2021
@alessio alessio added this to the 0.39.3 - The Launchpad Series milestone Feb 27, 2021
fedekunze
fedekunze approved these changes Feb 28, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@alessio alessio merged commit bd1897c into launchpad/backports Mar 1, 2021
@alessio alessio deleted the zaki-backport-genesis-speed-up-to-launchpad branch March 1, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@fedekunze fedekunze fedekunze approved these changes

@clevinson clevinson Awaiting requested review from clevinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.39.3 - The Launchpad Series
Development

Successfully merging this pull request may close these issues.
5 participants
@zmanian @alessio @tac0turtle @fedekunze @odeke-em