-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow REST endpoint to query txs with multisig (bp #8730) #8731
Conversation
* Fix unpack stdtx * Add test for multisig * remove println * Add changelog * Better UnpackInterfaces Co-authored-by: Alessio Treglia <alessio@tendermint.com> (cherry picked from commit 3832860) # Conflicts: # CHANGELOG.md
CHANGELOG will be finalised before release
Codecov Report
@@ Coverage Diff @@
## release/v0.41.x #8731 +/- ##
===================================================
+ Coverage 61.93% 61.96% +0.03%
===================================================
Files 611 611
Lines 35250 35382 +132
===================================================
+ Hits 21831 21926 +95
- Misses 11136 11156 +20
- Partials 2283 2300 +17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alessio Did you remove my entry in the changelog bugfix section on purpose? Are you planning to create that section in one run for all backport PRs?
Yes correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold on - tests are failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are syntax errors on rest tests.
This is an automatic backport of pull request #8730 done by Mergify.
Cherry-pick of 3832860 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/