Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow REST endpoint to query txs with multisig (bp #8730) #8731

Merged
merged 4 commits into from
Mar 1, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 1, 2021

This is an automatic backport of pull request #8730 done by Mergify.

Cherry-pick of 3832860 has failed:

On branch mergify/bp/release/v0.41.x/pr-8730
Your branch is up to date with 'origin/release/v0.41.x'.

You are currently cherry-picking commit 383286026.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/auth/client/rest/rest_test.go
	modified:   x/auth/legacy/legacytx/stdsign.go
	modified:   x/auth/legacy/legacytx/stdtx.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* Fix unpack stdtx

* Add test for multisig

* remove println

* Add changelog

* Better UnpackInterfaces

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
(cherry picked from commit 3832860)

# Conflicts:
#	CHANGELOG.md
CHANGELOG will be finalised before release
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #8731 (54d9ee5) into release/v0.41.x (2a5818c) will increase coverage by 0.03%.
The diff coverage is 62.50%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.41.x    #8731      +/-   ##
===================================================
+ Coverage            61.93%   61.96%   +0.03%     
===================================================
  Files                  611      611              
  Lines                35250    35382     +132     
===================================================
+ Hits                 21831    21926      +95     
- Misses               11136    11156      +20     
- Partials              2283     2300      +17     
Impacted Files Coverage Δ
baseapp/grpcserver.go 2.70% <0.00%> (+0.13%) ⬆️
store/rootmulti/store.go 66.05% <0.00%> (ø)
testutil/network/network.go 90.54% <0.00%> (ø)
x/auth/legacy/legacytx/stdsign.go 82.97% <ø> (ø)
x/staking/keeper/keeper.go 56.66% <ø> (-1.40%) ⬇️
x/staking/keeper/validator.go 80.52% <ø> (+0.03%) ⬆️
client/grpc_query.go 29.16% <40.00%> (+0.90%) ⬆️
baseapp/grpcrouter.go 80.00% <50.00%> (-6.05%) ⬇️
x/auth/legacy/legacytx/stdtx.go 80.85% <50.00%> (-1.38%) ⬇️
x/auth/client/cli/tx_multisign.go 64.67% <68.46%> (+2.99%) ⬆️
... and 12 more

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessio Did you remove my entry in the changelog bugfix section on purpose? Are you planning to create that section in one run for all backport PRs?

@alessio
Copy link
Contributor

alessio commented Mar 1, 2021

@alessio Did you remove my entry in the changelog bugfix section on purpose? Are you planning to create that section in one run for all backport PRs?

Yes correct

alessio
alessio previously requested changes Mar 1, 2021
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on - tests are failing

Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are syntax errors on rest tests.

@amaury1093 amaury1093 added this to the v0.41.4 milestone Mar 1, 2021
@alessio alessio dismissed their stale review March 1, 2021 15:41

dismissing

@alessio alessio merged commit b8134c1 into release/v0.41.x Mar 1, 2021
@alessio alessio deleted the mergify/bp/release/v0.41.x/pr-8730 branch March 1, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants