Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --output-document to multisign-batch #8873

Merged
merged 4 commits into from
Mar 15, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 14, 2021

Closes: #8870


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #8873 (452e6ac) into master (c6af0ed) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8873   +/-   ##
=======================================
  Coverage   59.15%   59.15%           
=======================================
  Files         570      570           
  Lines       31770    31774    +4     
=======================================
+ Hits        18793    18797    +4     
+ Misses      10776    10775    -1     
- Partials     2201     2202    +1     
Impacted Files Coverage Δ
server/test_helpers.go 0.00% <0.00%> (ø)
x/auth/client/cli/tx_multisign.go 64.88% <71.42%> (+0.04%) ⬆️
x/auth/client/cli/tx_sign.go 74.59% <100.00%> (ø)

@alessio alessio added A:automerge Automatically merge PR once all prerequisites pass. backport/0.42.x (Stargate) labels Mar 14, 2021
@orijbot
Copy link

orijbot commented Mar 14, 2021

@orijbot
Copy link

orijbot commented Mar 15, 2021

@orijbot
Copy link

orijbot commented Mar 15, 2021

@mergify mergify bot merged commit 5f71e93 into master Mar 15, 2021
@mergify mergify bot deleted the alessio/8870-output-document-flag branch March 15, 2021 12:18
mergify bot pushed a commit that referenced this pull request Mar 15, 2021
Closes: #8870

Co-authored-by: SaReN <sahithnarahari@gmail.com>
(cherry picked from commit 5f71e93)
alessio pushed a commit that referenced this pull request Mar 15, 2021
Closes: #8870

Co-authored-by: SaReN <sahithnarahari@gmail.com>
(cherry picked from commit 5f71e93)

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multisign-batch does not support the --output-document flag
4 participants