add +nobuild flags to all relevant test cases

[alessio]

CLI tests must be excluded by race detection due
to a well-known Tendermint issue.

Closes: #8923

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[orijbot]

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=cf484e86b24a421fb7f239742bbb0518

[orijbot]

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=1fe0ee1952bd5e6b4121b1c5c53c274b328ffda0

[tac0turtle]

looks fine. Can you point out what the "well-known issue in tendermint" is? Do we have an issue for this?

[fdymylja]

--- FAIL: TestIntegrationTestSuite/TestBroadcastTx_GRPCGateway (1.03s)
      --- FAIL: TestIntegrationTestSuite/TestBroadcastTx_GRPCGateway/valid_request (0.00s)
          service_test.go:454: 
              	Error Trace:	service_test.go:454
              	            				suite.go:77
              	Error:      	Not equal: 
              	            	expected: 0x0
              	            	actual  : 0x13
              	Test:       	TestIntegrationTestSuite/TestBroadcastTx_GRPCGateway/valid_request
              	Messages:   	rawlog%!(EXTRA string=)

^ tests failing are unrelated to this PR, I've seen this fail quite frequently in the past weeks. We probably should open a separate issue for this.

[orijbot]

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=be5f1e77a31942f9a7f0901f19473203

[orijbot]

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=7b09f95ab5bed044ef9c74de0c7b093cf26ef648

[alessio]

looks fine. Can you point out what the "well-known issue in tendermint" is? Do we have an issue for this?

Look at the package testutil/network. Running two Tendermint instances at the same time makes the tests panic.

[tac0turtle]

Is there an issue for this in tendermint? if not, want to open it?

[alexanderbez]

looks fine. Can you point out what the "well-known issue in tendermint" is? Do we have an issue for this?

Look at the package testutil/network. Running two Tendermint instances at the same time makes the tests panic.

This is already well known and I've documented it: https://github.com/cosmos/cosmos-sdk/blob/master/testutil/network/doc.go#L16-L20

[robert-zaremba]

Thanks for the link.

BTW:

Package network implements and exposes a fully operational in-process Tendermint test network that consists of at least one or potentially many validators. This test network can be used primarily for integration tests or unit test suites.

This doesn't sound like anything close to unit tests 😅

[alessio]

Thanks for the link.

BTW:

Package network implements and exposes a fully operational in-process Tendermint test network that consists of at least one or potentially many validators. This test network can be used primarily for integration tests or unit test suites.

This doesn't sound like anything close to unit tests

Yes, that comment needs to be updated 👍