Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add Abs() method to sdk.Int #8963

Merged
merged 5 commits into from
Mar 24, 2021
Merged

types: add Abs() method to sdk.Int #8963

merged 5 commits into from
Mar 24, 2021

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Mar 23, 2021

Fixes #8962

Description

Add Abs() method to sdk.Int.

closes: #8962


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #8963 (bea1e9c) into master (56c312a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bea1e9c differs from pull request most recent head 9b32220. Consider uploading reports for the commit 9b32220 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8963   +/-   ##
=======================================
  Coverage   58.88%   58.88%           
=======================================
  Files         571      571           
  Lines       32118    32116    -2     
=======================================
- Hits        18912    18911    -1     
+ Misses      10984    10983    -1     
  Partials     2222     2222           
Impacted Files Coverage Δ
types/int.go 72.91% <100.00%> (+0.38%) ⬆️
x/bank/keeper/send.go 83.62% <0.00%> (-0.87%) ⬇️
x/bank/keeper/keeper.go 72.91% <0.00%> (-0.28%) ⬇️
simapp/test_helpers.go 0.49% <0.00%> (+<0.01%) ⬆️

@hallazzang hallazzang marked this pull request as ready for review March 24, 2021 04:12
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ackd

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!!

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 24, 2021
@mergify mergify bot merged commit 8ee9da7 into cosmos:master Mar 24, 2021
@orijbot
Copy link

orijbot commented Mar 24, 2021

@orijbot
Copy link

orijbot commented Mar 24, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Abs() method to sdk.Int
5 participants