-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module/types code hygiene - utilize map access 2nd return value #9098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
added
the
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
label
Apr 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #9098 +/- ##
=======================================
Coverage 58.79% 58.79%
=======================================
Files 583 583
Lines 32750 32750
=======================================
Hits 19255 19255
Misses 11218 11218
Partials 2277 2277
|
amaury1093
approved these changes
Apr 13, 2021
tac0turtle
approved these changes
Apr 13, 2021
tac0turtle
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Apr 13, 2021
9 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
…os#9098) * update docs/code to utilize map access return values * remove mock module in fromVM to simulate truly non-existent module * update test docs to refelect change Co-authored-by: technicallyty <48813565+tytech3@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up a small snippet of code in types/module/module.go
Currently, to check if a module exists in the fromVM map, we check for the default/nil value in the map.
This PR utilizes the 2nd return value from map accesses, a boolean, which is true if the key exists in the map, false otherwise. This makes not only the code a bit more readable, but also the documentation surrounding it. Ref: In-Place store migration docs.
closes: N/A
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes