-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/feegrant completeness audit updates #9177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9177 +/- ##
==========================================
+ Coverage 59.72% 59.86% +0.13%
==========================================
Files 595 595
Lines 37346 37355 +9
==========================================
+ Hits 22306 22361 +55
+ Misses 13059 13011 -48
- Partials 1981 1983 +2
|
blushi
requested review from
atheeshp,
amaury1093,
aleem1314,
clevinson,
cyberbono3,
technicallyty,
robert-zaremba and
anilcse
April 23, 2021 09:25
9 tasks
anilcse
reviewed
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just small nits
atheeshp
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
aleem1314
reviewed
Apr 27, 2021
aleem1314
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #9115
Address x/feegrant completeness audit updates:
InitGenesis
in case of errorQueryServer
inx/feegrant/keeper/grpc_query.go
is not covered by tests inx/feegrant/keeper/keeper_test.go
but indirectly inx/feegrant/client/rest/grpc_query_test.go
using grpc-gateway REST endpoints. Thisx/feegrant/client/rest
folder must be some leftovers of legacy REST routes from the initial feegrant module implementation but it doesn't make sense to keep it since the module doesn't support legacy REST routes. Those tests should be moved tox/feegrant/keeper/keeper_test.go
.Use
field, we usegranter
andgrantee
as arguments names in one command and in the other one, we usegranter_address
andgrantee_address
. It would be good to have consistent naming across all feegrant commands.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes