-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/feegrant remove height base expiration #9206
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9206 +/- ##
==========================================
+ Coverage 60.13% 60.16% +0.03%
==========================================
Files 595 594 -1
Lines 37185 37106 -79
==========================================
- Hits 22360 22325 -35
+ Misses 12846 12805 -41
+ Partials 1979 1976 -3
|
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but could you update the ADR as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
ref: #9115
Get rid of block height in ExportGenesis and remove height support in general and get rid of
PrepareForExport
method fromFeeAllowanceI
interface.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes