Add client config subcommand to CLI (backport #8953) #9255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add client config * addressed reviewers comments * refactored,ready for review * fixed linter issues and addressed reviewers comments * Bump golangci-lint * fix linter warnings * fix some tests Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
|
Hmm, linting fails on unchanged files https://github.com/cosmos/cosmos-sdk/runs/2565206545. How can I fix this? |
amaury1093
commented
May 12, 2021
1 task
| ./build/simd init andrei --home ./test | ||
| cd test/config there is no client.toml configuration file | ||
| */ | ||
| func ReadHomeFlag(clientCtx Context, cmd *cobra.Command) Context { |
There was a problem hiding this comment.
I would call that function SetHomeFromFlag, but it's too late.
robert-zaremba
approved these changes
May 12, 2021
robert-zaremba
added
the
A:automerge
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports: #8953
add client config
addressed reviewers comments
refactored,ready for review
fixed linter issues and addressed reviewers comments
Bump golangci-lint
fix linter warnings
fix some tests
Co-authored-by: Alessio Treglia alessio@tendermint.com
Co-authored-by: Amaury 1293565+amaurym@users.noreply.github.com
Description
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes