-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: store key uniqueness #9363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
aaronc,
alessio,
alexanderbez,
AdityaSripal,
fedekunze,
technicallyty and
aleem1314
May 19, 2021 09:56
alexanderbez
approved these changes
May 19, 2021
technicallyty
suggested changes
May 19, 2021
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
so, |
technicallyty
approved these changes
May 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
robert-zaremba
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
May 20, 2021
roysc
pushed a commit
to vulcanize/cosmos-sdk
that referenced
this pull request
Jun 23, 2021
* fix: store key uniqueness * gosimple: use copy instead of for loop * Update types/store.go Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com> * fix import Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing the module store keys and app wiring I notice that we don't correctly check for collisions, which can happen when:
It's also not clear to me why we need all this different types:
They don't really protect against collision, neither pointers - because modules will reference store keys by name.
PS: I didn't create an issue - just went ahead and updated the code.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes