feat: add version params to parameters #9432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9432 +/- ##
==========================================
- Coverage 63.46% 63.43% -0.03%
==========================================
Files 571 571
Lines 37524 37524
==========================================
- Hits 23815 23804 -11
- Misses 11851 11862 +11
Partials 1858 1858
|
tac0turtle
changed the title
tac0turtle
added
S:blocked
likhita-809
reviewed
Jun 15, 2021
alexanderbez
approved these changes
Jun 15, 2021
How does baseapp params handle migration. I dont see a migration script in there. |
amaury1093
reviewed
Jun 28, 2021
4 tasks
amaury1093
reviewed
Jun 29, 2021
tac0turtle
force-pushed
the
marko/7472_versionparams
branch
from
d3fb6ad to
2d63a91
Compare
tac0turtle
added
A:automerge
amaury1093
approved these changes
Jul 8, 2021
| func ConsensusParamsKeyTable() types.KeyTable { | ||
| return types.NewKeyTable( | ||
| types.NewParamSetPair( | ||
| func ConsensusParamsKeyTable() KeyTable { |
There was a problem hiding this comment.
Could we add an API breaking changelog entry for this guy?
amaury1093
removed
the
A:automerge
|
will open another PR. the bot moved too fast |
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description add version paramters to Tendermint consensus params. closes: cosmos#7472 @AmauryM this may need to be incorporated into the upgrade module. I need to read into how upgrades work to figure it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add version paramters to Tendermint consensus params.
closes: #7472
@AmauryM this may need to be incorporated into the upgrade module. I need to read into how upgrades work to figure it out.