Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: note flag description #9436

Merged
merged 2 commits into from
Jun 2, 2021
Merged

fix: note flag description #9436

merged 2 commits into from
Jun 2, 2021

Conversation

ryanchristo
Copy link
Contributor

@ryanchristo ryanchristo commented Jun 1, 2021

Description

This is a follow up pull request to #9134 / #9122.

The use of backticks around --memo in the flag description causes the input type to show up as --memo:

regen tx bank send -h

--note --memo              Note to add a description to the transaction (previously --memo)

And without backticks around --memo:

regen tx bank send -h

--note string              Note to add a description to the transaction (previously --memo)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards. -n/a
  • Wrote unit and integration tests -n/a
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/) -n/a
  • Added relevant godoc comments. -n/a
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md -n/a
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@github-actions github-actions bot added the C:CLI label Jun 1, 2021
@ryanchristo ryanchristo changed the title fix: memo flag description fix: note flag description Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #9436 (a4e60cc) into master (2ae7875) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9436   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         589      589           
  Lines       37099    37099           
=======================================
  Hits        22405    22405           
  Misses      12715    12715           
  Partials     1979     1979           
Impacted Files Coverage Δ
client/flags/flags.go 22.22% <0.00%> (ø)

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 2, 2021
@mergify mergify bot merged commit 33c045c into master Jun 2, 2021
@mergify mergify bot deleted the ryan/fix-memo-flag branch June 2, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants